Skip to content

Conversation

alessandroboron
Copy link
Contributor

@alessandroboron alessandroboron commented Oct 15, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211135074300531
Tech Design URL:
CC:

Description

Implements UI for What’s New iOS.

NOTE: The light mode background does not look like the design. I’m opening a follow-up task to talk to David about it. The dark gradient, however, looks like the design.

Screenshots

iPhone 16
iPhone16

iPhone SE
iPhoneSE

iPad Mini
iPadMini

iPad
iPad

Testing Steps

  1. Ensure Screenshots are close to Figma Mockup
  2. Check SwiftUI Preview for look and feel.

Impact and Risks

None, merging into the main feature branch.

What could go wrong?

Quality Considerations

Notes to Reviewer


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Implements a SwiftUI “What’s New” cards list UI and adds new remote message placeholders (ImageAI, Radar, KeyImport) with mapping, tests, and assets.

  • iOS UI:
    • Add UI/CardsListView.swift implementing a SwiftUI cards list (“What’s New”) with gradient background and primary action.
    • Add RemoteMessage.xcassets with RemoteImageAI, RemoteRadar, RemoteKeyImport icons; wire into Xcode project.
  • Remote Messaging:
    • Extend placeholders in RemotePlaceholder (now CaseIterable) and RemoteMessageResponse.JsonPlaceholder with imageAI, radar, keyImport.
    • Update JsonToRemoteMessageModelMapper.mapToPlaceholder and related mapping to support new placeholders.
  • Tests:
    • Add JsonToRemoteMessageModelMapperPlaceholdersTests.swift and JSON fixture remote-messaging-config-placeholders.json to verify placeholder mapping (messages and list items).
  • Build/Project:
    • Include new test resource in Package.swift and add new UI files/assets to the Xcode project.

Written by Cursor Bugbot for commit 3fbf079. This will update automatically on new commits. Configure here.

Copy link

github-actions bot commented Oct 15, 2025

Warnings
⚠️ PR has 820 lines of added code (excluding Xcode projects and assets). Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 3fbf079

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
2 minor things:

  • Some naming analysts parameter naming in the testing file seems wrong (probably from copy paste?)
  • The chevron colour seems darker than in Figma
  • We already talked about the light mode gradient so that will be resolved later

@alessandroboron
Copy link
Contributor Author

LGTM! 2 minor things:

  • Some naming analysts parameter naming in the testing file seems wrong (probably from copy paste?)
  • The chevron colour seems darker than in Figma
  • We already talked about the light mode gradient so that will be resolved later

oops! yes it was from copying and adapting existing tests. Fixed it.

cursor[bot]

This comment was marked as outdated.

@alessandroboron alessandroboron force-pushed the alessandro/whats-new-ui branch from 6903af7 to 5928195 Compare October 16, 2025 00:32
@alessandroboron alessandroboron merged commit 1a02791 into alessandro/whats-new Oct 16, 2025
43 checks passed
@alessandroboron alessandroboron deleted the alessandro/whats-new-ui branch October 16, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants