-
Notifications
You must be signed in to change notification settings - Fork 31
[RMF][What’s New] Implement UI #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alessandroboron
merged 7 commits into
alessandro/whats-new
from
alessandro/whats-new-ui
Oct 16, 2025
Merged
[RMF][What’s New] Implement UI #2211
alessandroboron
merged 7 commits into
alessandro/whats-new
from
alessandro/whats-new-ui
Oct 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabrinaTardio
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2 minor things:
- Some naming analysts parameter naming in the testing file seems wrong (probably from copy paste?)
- The chevron colour seems darker than in Figma
- We already talked about the light mode gradient so that will be resolved later
oops! yes it was from copying and adapting existing tests. Fixed it. |
6903af7
to
5928195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211135074300531
Tech Design URL:
CC:
Description
Implements UI for What’s New iOS.
NOTE: The light mode background does not look like the design. I’m opening a follow-up task to talk to David about it. The dark gradient, however, looks like the design.
Screenshots
iPhone 16

iPhone SE

iPad Mini

iPad

Testing Steps
Impact and Risks
None, merging into the main feature branch.
What could go wrong?
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Implements a SwiftUI “What’s New” cards list UI and adds new remote message placeholders (ImageAI, Radar, KeyImport) with mapping, tests, and assets.
UI/CardsListView.swift
implementing a SwiftUI cards list (“What’s New”) with gradient background and primary action.RemoteMessage.xcassets
withRemoteImageAI
,RemoteRadar
,RemoteKeyImport
icons; wire into Xcode project.RemotePlaceholder
(nowCaseIterable
) andRemoteMessageResponse.JsonPlaceholder
withimageAI
,radar
,keyImport
.JsonToRemoteMessageModelMapper.mapToPlaceholder
and related mapping to support new placeholders.JsonToRemoteMessageModelMapperPlaceholdersTests.swift
and JSON fixtureremote-messaging-config-placeholders.json
to verify placeholder mapping (messages and list items).Package.swift
and add new UI files/assets to the Xcode project.Written by Cursor Bugbot for commit 3fbf079. This will update automatically on new commits. Configure here.