-
Notifications
You must be signed in to change notification settings - Fork 31
macOS: Add Duck.ai chats toggle UI to fire button and history dialogs #2195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rachelmcr
wants to merge
7
commits into
rachel/chat-history-merged-changes
Choose a base branch
from
rachel/chat-history-fire-dialog
base: rachel/chat-history-merged-changes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
macOS: Add Duck.ai chats toggle UI to fire button and history dialogs #2195
rachelmcr
wants to merge
7
commits into
rachel/chat-history-merged-changes
from
rachel/chat-history-fire-dialog
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apologies, I messed up the commits here; I’ll get them fixed ASAP |
440589e
to
3f752dd
Compare
Ok, this branch is fixed and the PR includes only the new commits. |
diegoreymendez
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only comment is this isn't clearing - but we spoke via DM and that's expected as this is only UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1209825025475019/task/1211397736375307?focus=true
Tech Design URL:
CC: @diegoreymendez
Description
This adds a “Duck.ai chats” toggle to the new fire dialog, so Duck.ai chats can be cleared when using the fire button or deleting history:
If the new fire dialog is not enabled (a fallback in case
fireDialog
feature flag is disabled):Testing Steps
With new fire dialog:
With new history dialog:
With production fire dialog:
With production history dialog:
Optional testing scenarios:
defaults delete com.duckduckgo.macos.browser.debug featureUsedBefore_aiChat
to simulate a user who hasn’t used Duck.ai before, click the fire button, and confirm the toggle is not visible.Impact and Risks
Low: Minor visual changes, small bug fixes, improvement to existing features
What could go wrong?
Toggle is non-functional but could show up to users; it is feature flagged and has been manually tested.
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Adds a feature-flagged Duck.ai chats clearing option (UI + settings) on macOS, wires visibility via a new AIChatHistoryCleaner and FeatureDiscovery notifications, updates strings/UI, and expands tests and project wiring.
Duck.ai chats
toggle; include inFireDialogResult
and flow; update labels (e.g., active tabs info) and dynamic sizing.AIChatHistoryCleaner
intoAppDelegate
,DataClearingPreferences
,FireCoordinator
, andFirePopoverViewController
.AIChatHistoryCleaner
determines visibility (depends on usage, AI Chat visibility, andclearAIChatHistory
feature flag).FeatureFlag.clearAIChatHistory
; exposeWasUsedBeforeFeature.storageKey
and post.featureDiscoverySetWasUsedBefore
notification inDefaultFeatureDiscovery
.AIChatSubfeature.clearAIChatHistory
(BrowserServicesKit).UserText
andNSAlert.autoClearAlert(...)
to reflect chat deletion scenarios.FeatureDiscovery
; imports updated.AIChatHistoryCleanerTests
,DefaultFeatureDiscoveryTests
); migrate toBrowserServicesKitTestsUtils
; project files updated.Written by Cursor Bugbot for commit 3f752dd. This will update automatically on new commits. Configure here.