-
Notifications
You must be signed in to change notification settings - Fork 31
Win-back offer: macOS entry points #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and all worked according to the test steps. 👍
.frame(maxWidth: .infinity) | ||
.frame(height: Constants.buttonHeight) | ||
} | ||
.frame(height: 28) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be extracted to constants, and for the following button too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll address this in the following PR.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211494295271896
Tech Design URL: https://app.asana.com/1/137249556945/project/481882893211075/task/1211375835464498
CC:
Description
This PR adds the following macOS entry points for the win-back offer:
Testing Steps
Impact and Risks
None, everything is behind feature flag
What could go wrong?
N/A
Quality Considerations
I’ve added tests for the menu/sidebar behaviors.
Notes to Reviewer
A few caveats below:
—
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Implements macOS win‑back offer entry points (modal, menu/sidebar badges, preferences updates, NTP banner scaffolding) and exposes shared storage/manager with new state while adding strings, assets, and tests.
MoreOptionsMenu
shows “SAVE 25%” onSubscription
when offer available; layout tweaks toMenuItemWithBadge
.Subscription
.WinbackOfferStoring
/WinBackOfferVisibilityManaging
public; adddidDismissUrgencyMessage
state.dateProvider
; replace directDate()
usage; minor logic refactors.Written by Cursor Bugbot for commit b7dcd11. This will update automatically on new commits. Configure here.