Skip to content

Conversation

mallexxx
Copy link
Contributor

@mallexxx mallexxx commented Oct 9, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200194497630846/task/1211595713471267?focus=true

Description

Testing Steps

  1. Do some basic smoke testing (favicons, file download, bookmarks, history, burning)
  2. Validate CI is green

Impact and Risks

What could go wrong?

Quality Considerations

Notes to Reviewer


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Reorganizes test/util code into new local packages, updates imports and API visibility, adjusts project resources/paths, and minor fixes (e.g., bookmarks import dependency, WebView/test tweaks).

  • Build/Project Structure:
    • Add new local packages: TestsExtensions (SharedTestUtilities, SharedSandboxTestUtilities, TestsObjCExtensions) and Utilities; remove ObjCTestsExtensions.
    • Update Xcode project references, frameworks, and resources (e.g., move autoconsent JS and TabBar.storyboard into Resources).
    • Remove obsolete bridging headers; clean up targets and file locations.
  • Code Visibility & Extensions:
    • Make several types public (e.g., FilePresenter, SecurityScopedFileURLController, NSCoder/NSImage extensions, helpers) and add new Utilities CoreData encryption helpers.
    • Migrate/rename extensions (e.g., CGSize.fixedLayout, NSImage helpers) and adjust imports across modules.
  • Feature/Logic Tweaks:
    • WebView: add method to reset loading observer for tests; minor AppDelegate/Database import adjustments.
    • Bookmarks import now uses Bookmarks module; add Bookmarks dependency in Package.swift.
    • Increase watchdog test max duration; rollup paths updated.
  • Tests:
    • Move mocks/utilities into SharedTestUtilities; add/rename test files (encryption, history, downloads, onboarding); remove duplicates; update usages.

Written by Cursor Bugbot for commit d4ec3b7. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

Copy link

github-actions bot commented Oct 9, 2025

Warnings
⚠️ PR has 1771 lines of added code (excluding Xcode projects and assets). Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against d4ec3b7

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant