Skip to content

Conversation

mallexxx
Copy link
Contributor

@mallexxx mallexxx commented Oct 8, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211191646967416?focus=true
CC @shakyShane

Description

  • Add Sites section to the History View

Testing Steps

  1. Activate historyViewSitesSectionSubfeature feature flag override
  2. Open History
  3. Validate Sites section works
  4. Delete data for all/individual/multiple selected sites;
  5. Validate all Context menu items for sites

Impact and Risks

Low

What could go wrong?

Incorrect data in Sites section

Quality Considerations

Notes to Reviewer


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Adds a new Sites section to History (behind a flag) with site-level filtering and deletion, updated URL/routing, UI, and extensive tests; also updates content scripts and locales.

  • History View (macOS):
    • Add new Sites section (HistoryRange.allSites) with unique domain grouping, counts, favicon/title selection, and batching.
    • New feature flag historyViewSitesSection (and privacy subfeature sitesSection).
    • HistoryViewDataProvider: builds synthetic sites grouping, preferredURL/bestTitle helpers, ranges include Sites.
    • HistoryViewActionsHandler: support site: entries (context menu, copy/open, delete routes via domainFilter).
    • Add icon pages/history/icons/sites.svg and locales/strings for "Sites".
  • Fire Dialog/Coordinator:
    • Consider allSites in flows; UI polish (rounded corners, dark color tweak, section row enabling) and links to History Sites.
    • FireCoordinator burn logic updated; numerous integration tests added.
  • URL/Routing & Tab Model:
    • Support history pane via query/path (duck://history?range=...), TabContent.history(pane:), state restoration.
    • New URL.historyPane(_:), HistoryPaneIdentifier.init(url:).
  • Feature Flags:
    • Introduce historyViewSitesSection; expose DispatchQueue extension public.
  • Content Scope Scripts:
    • Remove duckAiDataClearing; add device enumeration prevention; Android viewport fix tweaks; autofill import key rename; platform feature lists updated.
  • New Tab UI:
    • Omnibar popover styling and copy tweaks; input font adjustment.
  • Tests:
    • Large set of unit/integration tests for history, URL parsing, fire flows; @MainActor annotations.
  • Misc:
    • Update dependencies (content-scope-scripts), strings across locales; minor project changes.

Written by Cursor Bugbot for commit 2e9badf. This will update automatically on new commits. Configure here.

@mallexxx mallexxx requested a review from ayoy October 8, 2025 12:13
@mallexxx mallexxx changed the base branch from main to alex/add-fireproof-domains October 8, 2025 12:13
Copy link

github-actions bot commented Oct 8, 2025

Warnings
⚠️ PR has 3470 lines of added code (excluding Xcode projects and assets). Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See iOS and macOS localization guidelines for more information.

Generated by 🚫 dangerJS against 2e9badf

cursor[bot]

This comment was marked as outdated.

@ayoy ayoy self-assigned this Oct 9, 2025
cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mallexxx this is working great, thanks a lot 🎉

I’m leaving a few minor comments about the DI and naming, otherwise it’s good to go (pending C-S-S update to pull in “Sites” name from native, which we’ve talked about in MM).

@ayoy ayoy assigned mallexxx and unassigned ayoy Oct 9, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants