-
Notifications
You must be signed in to change notification settings - Fork 31
History sites section #2143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alex/add-fireproof-domains
Are you sure you want to change the base?
History sites section #2143
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mallexxx this is working great, thanks a lot 🎉
I’m leaving a few minor comments about the DI and naming, otherwise it’s good to go (pending C-S-S update to pull in “Sites” name from native, which we’ve talked about in MM).
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211191646967416?focus=true
CC @shakyShane
Description
Testing Steps
historyViewSitesSectionSubfeature
feature flag overrideImpact and Risks
Low
What could go wrong?
Incorrect data in Sites section
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Adds a new Sites section to History (behind a flag) with site-level filtering and deletion, updated URL/routing, UI, and extensive tests; also updates content scripts and locales.
Sites
section (HistoryRange.allSites
) with unique domain grouping, counts, favicon/title selection, and batching.historyViewSitesSection
(and privacy subfeaturesitesSection
).HistoryViewDataProvider
: builds synthetic sites grouping,preferredURL
/bestTitle
helpers, ranges include Sites.HistoryViewActionsHandler
: supportsite:
entries (context menu, copy/open, delete routes via domainFilter).pages/history/icons/sites.svg
and locales/strings for "Sites".allSites
in flows; UI polish (rounded corners, dark color tweak, section row enabling) and links to History Sites.FireCoordinator
burn logic updated; numerous integration tests added.duck://history?range=...
),TabContent.history(pane:)
, state restoration.URL.historyPane(_:)
,HistoryPaneIdentifier.init(url:)
.historyViewSitesSection
; exposeDispatchQueue
extension public.duckAiDataClearing
; add device enumeration prevention; Android viewport fix tweaks; autofill import key rename; platform feature lists updated.@MainActor
annotations.content-scope-scripts
), strings across locales; minor project changes.Written by Cursor Bugbot for commit 2e9badf. This will update automatically on new commits. Configure here.