Skip to content

Conversation

mallexxx
Copy link
Contributor

@mallexxx mallexxx commented Oct 8, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1142021229838617/task/1211586281230235?focus=true

Description

  • add Add, Add Current site buttons to the Manage Fireproof Sites dialog

Testing Steps

  1. open the Manage Fireproof domains dialog from Settings -> Data Clearing: validate no blinking and favicons are shown with letters for missing favicons, Add button should display an alert and domain should be added, Add button should be disabled when invalid domain name is entered
  2. Activate "fireDialog" feature flag; open fire dialog from the Fire Dialog using the "Manage" buttons
  3. Validate Add Current button only enabled when there's a correct websites loaded
  4. Validate cmd+z removes added site, cmd+shift+z re-adds it

Impact and Risks

Low

What could go wrong?

Incorrect "Add" sites buttons behavior

Quality Considerations

Notes to Reviewer


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Adds Add/Add Current buttons to Fireproof manager with validated input prompt, eTLD+1 normalization, and improved undo/redo handling.

  • UI (macOS Fireproof Manager):
    • Add Add and Add Current buttons in Preferences/View/FireproofDomainsViewController.swift with accessibility IDs and toolbar styling.
    • Implement addDomain(_:) sheet with live validation, optional prefill from current tab host, and addition via addDomainSilently.
    • Implement addCurrentDomain(_:) and updateAddCurrentButtonState() to enable/disable based on selected tab URL and fireproof status.
    • Centralize undo/redo with addDomainSilently and removeDomainSilently; apply to remove-selected and remove-all flows, and avoid resetting action names during undo.
  • Model:
    • Add FireproofDomains.normalizedHost(fromUserInput:) to validate/normalize user input to eTLD+1 and de-duplicate.
  • Alerts:
    • Add NSAlert.fireproofAddDomainPrompt() to present input field for adding a fireproof domain.

Written by Cursor Bugbot for commit d880e6d. This will update automatically on new commits. Configure here.

@mallexxx mallexxx requested a review from tomasstrba October 8, 2025 09:33
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅ Works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants