Add fireproof domains from Fireproof manager dialog #2140
+144
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1142021229838617/task/1211586281230235?focus=true
Description
Testing Steps
Impact and Risks
Low
What could go wrong?
Incorrect "Add" sites buttons behavior
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Adds Add/Add Current buttons to Fireproof manager with validated input prompt, eTLD+1 normalization, and improved undo/redo handling.
Add
andAdd Current
buttons inPreferences/View/FireproofDomainsViewController.swift
with accessibility IDs and toolbar styling.addDomain(_:)
sheet with live validation, optional prefill from current tab host, and addition viaaddDomainSilently
.addCurrentDomain(_:)
andupdateAddCurrentButtonState()
to enable/disable based on selected tab URL and fireproof status.addDomainSilently
andremoveDomainSilently
; apply to remove-selected and remove-all flows, and avoid resetting action names during undo.FireproofDomains.normalizedHost(fromUserInput:)
to validate/normalize user input to eTLD+1 and de-duplicate.NSAlert.fireproofAddDomainPrompt()
to present input field for adding a fireproof domain.Written by Cursor Bugbot for commit d880e6d. This will update automatically on new commits. Configure here.