Remove email text field from Support form #2095

quanganhdo · 2025-10-02T18:57:16Z

Task/Issue URL: https://app.asana.com/1/137249556945/task/1211485803691789?focus=true
Tech Design URL:
CC:

Description

Testing Steps

Go through the support flow on macOS and iOS
Submit bug reports
You should see the new design without email field

Impact and Risks

Low

What could go wrong?

Note

Removes email input and direct API submission from the unified feedback forms on iOS/macOS, adds a contact-support link, and updates UI, localizations, docs, and tests accordingly.

Feedback (iOS/macOS):
- Remove userEmail, email UI, validation, and direct API submission (drop Networking/APIService deps) from UnifiedFeedbackFormViewModel and views; enable submit when text is present.
- Add support link (contactSupportClick) opening https://duckduckgo.com/subscription-support; wire into iOS/macOS views.
- UI refinements: remove email TextField; improve iOS TextEditor background handling; macOS opens FAQ/support via app window manager.
Localizations:
- Remove email label/placeholder strings; tweak intro copy; add ppro.feedback-form.support.text.
Tests:
- Update feedback tests to new behavior (no email required; no API posting); adjust expectations; use MockAPIService { ... } style; minor Net Protection tests updated.
Docs:
- Update Networking/README.md mock example to closure-based MockAPIService.

^{Written by Cursor Bugbot for commit 805d826. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-02T18:58:27Z

	Messages
📖	You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See iOS and macOS localization guidelines for more information.

Generated by 🚫 dangerJS against 805d826

quanganhdo · 2025-10-02T19:27:39Z

iOS/DuckDuckGo/Subscription/Feedback/UnifiedFeedbackRootView.swift

+    private var editor: some View {
+        if #available(iOS 16.0, *) {
+            TextEditor(text: text)
+                .scrollContentBackground(.hidden)
+                .background(Color.clear)
+                .padding(.horizontal, 12)
+        } else {
+            TextEditor(text: text)
+                .padding(.horizontal, 12)
+                .background(Color.clear)
+                .onAppear { UITextView.appearance().backgroundColor = .clear }
+                .onDisappear { UITextView.appearance().backgroundColor = nil }
+        }


Borrowed this fix from ViewExtension.hideScrollContentBackground()

quanganhdo · 2025-10-02T19:29:16Z

macOS/DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormViewModel.swift


        if let url {
-            NSWorkspace.shared.open(url)
+            Application.appDelegate.windowControllersManager.show(url: url, source: .ui, newTab: true)


Nicer way to open the URL in a new tab

Copilot

Pull Request Overview

This PR removes the email text field from the unified feedback form across both macOS and iOS platforms, replacing it with a simple support link. The goal is to simplify the feedback form by eliminating the optional email field while still providing users with a way to contact support if needed.

Key Changes

Removed email field UI components and validation logic
Replaced email field with a support link that opens the DuckDuckGo subscription support page
Removed all email-related API submission logic since feedback is now anonymous
Updated test cases to reflect the removal of email functionality

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`macOS/DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormViewModel.swift`	Removed email properties, API submission logic, and added support link functionality
`macOS/DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormView.swift`	Replaced email field UI with support link component
`macOS/DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormViewController.swift`	Removed API service dependency from view model initialization
`iOS/DuckDuckGo/Subscription/Feedback/UnifiedFeedbackFormViewModel.swift`	Mirror of macOS changes - removed email handling and API submission
`iOS/DuckDuckGo/Subscription/Feedback/UnifiedFeedbackRootView.swift`	Replaced email field with support link in iOS UI
Various test files	Updated test cases to remove email-related assertions and API mocking
Localization files	Added support link text and marked email-related strings as stale

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

macOS/DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormViewModel.swift

iOS/DuckDuckGo/Subscription/Feedback/UnifiedFeedbackRootView.swift

…del.swift Fine Co-authored-by: Copilot <[email protected]>

github-actions · 2025-10-02T19:55:14Z

🌍 Smartling Translation Job Created

Job ID: dvtzf4aj8zsm
Platform: macOS

🔗 View in Smartling Dashboard

🔧 View Workflow Run

Next:

Review translation job
Authorize translation by adding the authorize translation label

github-actions · 2025-10-02T20:19:20Z

❌ Smartling Approval Failed

Job ID: dvtzf4aj8zsm
Platform: macOS
Error: Approval failed - check workflow logs

🔗 View in Smartling Dashboard

🔧 View Workflow Run

Next steps:
• Verify the job ID is correct
• Check if job has content to translate

github-actions · 2025-10-02T20:22:57Z

⏳ Smartling Job Status

Job ID: dvtzf4aj8zsm
Platform: macOS
Status: IN_PROGRESS
Progress: 58%

🔗 View in Smartling Dashboard
🔧 View Workflow Run

samsymons

Overall looks great! Tested on iOS, iPadOS in both regular and windowed mode, and macOS. A couple notes:

The iOS/iPadOS implementation won't open support tab in the browser if the browser isn't the default (instead opening in Safari)
The macOS implementation opens the support link in a new tab, but doesn't dismiss the feedback modal, which feels a little strange (iOS does dismiss the modal)

No blockers otherwise though and the implementation looks good on iOS 26, 18, and 17. I haven't been able to test older iOS versions as I'm having issues downloading those SDKs.

github-actions · 2025-10-14T00:20:47Z

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

github-actions · 2025-10-15T14:07:53Z

✅ Smartling Job Status

Job ID: dvtzf4aj8zsm
Platform: macOS
Status: COMPLETED
Progress: 100%

🔗 View in Smartling Dashboard
🔧 View Workflow Run

Next: Download translations with:
• Platform: macOS
• Action: download
• Job ID: dvtzf4aj8zsm

quanganhdo added 4 commits October 2, 2025 14:29

Update iOS version

e759225

Update macOS version

95dd807

Update strings

bd6a9c5

Fix URL opening in iOS

0b24bb1

quanganhdo added 3 commits October 2, 2025 15:02

Remove API call

9f861e0

Merge branch 'main' into anh/shared/ppro/no-more-email

5f2b11f

Fix iOS background

d40e859

quanganhdo commented Oct 2, 2025

View reviewed changes

quanganhdo added the start macos translation Starts macOS translation workflow via Smartling label Oct 2, 2025

quanganhdo marked this pull request as ready for review October 2, 2025 19:35

Copilot AI review requested due to automatic review settings October 2, 2025 19:35

Copilot AI reviewed Oct 2, 2025

View reviewed changes

macOS/DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormViewModel.swift Outdated Show resolved Hide resolved

iOS/DuckDuckGo/Subscription/Feedback/UnifiedFeedbackRootView.swift Show resolved Hide resolved

Update macOS/DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormViewMo…

ce3a42b

…del.swift Fine Co-authored-by: Copilot <[email protected]>

github-actions bot added needs translation authorization The Smartling translation job the PR is awaiting authorization. and removed start macos translation Starts macOS translation workflow via Smartling labels Oct 2, 2025

quanganhdo added the authorize translation Authorizes Smartling translation job for PR label Oct 2, 2025

github-actions bot removed the authorize translation Authorizes Smartling translation job for PR label Oct 2, 2025

Oops

a7b1bbe

quanganhdo added the check translation status Check status of Smartling translation job label Oct 2, 2025

github-actions bot added translation in progress The strings in this PR are being translated on Smartling and removed check translation status Check status of Smartling translation job needs translation authorization The Smartling translation job the PR is awaiting authorization. labels Oct 2, 2025

quanganhdo added 2 commits October 2, 2025 20:38

Update unit tests

8440511

Update test cases

089ed47

This comment was marked as outdated.

Sign in to view

quanganhdo requested a review from samsymons October 3, 2025 14:12

Merge branch 'main' into anh/shared/ppro/no-more-email

bdf0e22

samsymons approved these changes Oct 6, 2025

View reviewed changes

github-actions bot added the stale label Oct 14, 2025

quanganhdo added check translation status Check status of Smartling translation job and removed translation in progress The strings in this PR are being translated on Smartling labels Oct 15, 2025

Merge branch 'main' into anh/shared/ppro/no-more-email

805d826

github-actions bot added translations ready Translations are ready to download from Smartling and removed check translation status Check status of Smartling translation job stale labels Oct 15, 2025

Remove email text field from Support form #2095

Are you sure you want to change the base?

Remove email text field from Support form #2095

Uh oh!

Conversation

quanganhdo commented Oct 2, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing Steps

Impact and Risks

What could go wrong?

Uh oh!

github-actions bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quanganhdo Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

quanganhdo Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 2, 2025

🌍 Smartling Translation Job Created

Uh oh!

github-actions bot commented Oct 2, 2025

❌ Smartling Approval Failed

Uh oh!

github-actions bot commented Oct 2, 2025

⏳ Smartling Job Status

Uh oh!

This comment was marked as outdated.

Uh oh!

samsymons left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

✅ Smartling Job Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

quanganhdo commented Oct 2, 2025 •

edited by cursor bot

Loading

github-actions bot commented Oct 2, 2025 •

edited

Loading