Skip to content

Conversation

@malmstein
Copy link
Contributor

@malmstein malmstein commented Feb 3, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1213084636851473

Description

This PR creates a workflow to orchestrate all release steps


Note

Medium Risk
Medium risk because it changes release automation wiring and input handling across multiple GitHub Actions workflows, which can block or mis-route production releases if any called workflow still expects github.event.inputs values.

Overview
Adds a new Release Orchestrator workflow that sequences the release steps by calling existing workflows (release_create_tag, release_create_task, Play Store upload, then internal upload) with shared inputs and inherited secrets.

Updates release_create_tag.yml, release_create_task.yml, and release_tests.yml to support workflow_call inputs (with explicit type) and to consistently use ${{ inputs.* }} instead of ${{ github.event.inputs.* }} so they work both when dispatched manually and when invoked as reusable workflows.

Removes the standalone release_report_error.yml workflow.

Written by Cursor Bugbot for commit a8b3109. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein marked this pull request as ready for review February 3, 2026 22:00
@malmstein malmstein force-pushed the feature/david/02-03-gha_release_orchestrator branch from 0d25aad to a8b3109 Compare February 4, 2026 11:05
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

upload-internal:
needs: upload-play-store
uses: ./.github/workflows/release_upload_internal.yml
secrets: inherit No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing PLACEHOLDER validation allows invalid release tag creation

Medium Severity

The orchestrator workflow has a default value of PLACEHOLDER for app-version but lacks validation before passing it to child workflows. The create-release-tag job runs first and has no PLACEHOLDER check, meaning it could create a git tag named "PLACEHOLDER". The PLACEHOLDER validation only exists in release_create_task.yml, which runs after the tag is created. This allows accidental tag creation with invalid version strings.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants