-
Notifications
You must be signed in to change notification settings - Fork 1.2k
GHA: Release orchestrator #7655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
0d25aad to
a8b3109
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
| upload-internal: | ||
| needs: upload-play-store | ||
| uses: ./.github/workflows/release_upload_internal.yml | ||
| secrets: inherit No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing PLACEHOLDER validation allows invalid release tag creation
Medium Severity
The orchestrator workflow has a default value of PLACEHOLDER for app-version but lacks validation before passing it to child workflows. The create-release-tag job runs first and has no PLACEHOLDER check, meaning it could create a git tag named "PLACEHOLDER". The PLACEHOLDER validation only exists in release_create_task.yml, which runs after the tag is created. This allows accidental tag creation with invalid version strings.



Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1213084636851473
Description
This PR creates a workflow to orchestrate all release steps
Note
Medium Risk
Medium risk because it changes release automation wiring and input handling across multiple GitHub Actions workflows, which can block or mis-route production releases if any called workflow still expects
github.event.inputsvalues.Overview
Adds a new
Release Orchestratorworkflow that sequences the release steps by calling existing workflows (release_create_tag,release_create_task, Play Store upload, then internal upload) with shared inputs and inherited secrets.Updates
release_create_tag.yml,release_create_task.yml, andrelease_tests.ymlto supportworkflow_callinputs (with explicittype) and to consistently use${{ inputs.* }}instead of${{ github.event.inputs.* }}so they work both when dispatched manually and when invoked as reusable workflows.Removes the standalone
release_report_error.ymlworkflow.Written by Cursor Bugbot for commit a8b3109. This will update automatically on new commits. Configure here.