Create PageHeader Compose component and templates tab in ADS #7625
+528
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...rnal/src/main/java/com/duckduckgo/common/ui/internal/ui/component/templates/TemplatesPane.kt
Show resolved
Hide resolved
...design-system-internal/src/main/java/com/duckduckgo/common/ui/internal/ui/ADSComposeTools.kt
Show resolved
Hide resolved
GerardPaligot
force-pushed
the
feature/gerard/page-header-compose
branch
from
96574b2 to
2d653b6
Compare
GerardPaligot
force-pushed
the
feature/gerard/page-header-smartling
branch
from
22c8785 to
d872b05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1212015278241917/task/1211670072973939?focus=true
Description
Create DaxPageHeader component in Compose for settings screens.
Steps to test this PR
Check DaxPageHeader
UI changes
Note
Medium Risk
Medium risk: introduces new reusable Compose UI APIs (
DaxPageHeader,StatusIndicator/Status) and updates the internal demo pager, which could cause UI/resource regressions or naming collisions.Overview
Adds new Compose building blocks:
DaxPageHeader(optional icon/subtitle/body/status/learn-more CTA) andStatusIndicatorwith a sharedStatusenum.Extends the ADS demo by adding a Templates tab and fragment/pane that renders sample page headers, and refactors
setupThemedComposeViewto also support configuring a standaloneComposeView(not only viaView.findViewById).Written by Cursor Bugbot for commit 2d653b6. This will update automatically on new commits. Configure here.