Skip to content

Conversation

@catalinradoiu
Copy link
Contributor

@catalinradoiu catalinradoiu commented Jan 28, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1212898863116333?focus=true

Description

This PR improves the “What’s new” modal UI for tablet devices by:

  • Adding a maximum width constraint (600dp) to message components to prevent excessive stretching on larger screens
  • Creating responsive margins with different values for phones and tablets
  • Extracting dimension values to dedicated resource files for better maintainability

Steps to test this PR

Check the steps inside the following task to the the changes: https://app.asana.com/1/137249556945/project/1211724162604201/task/1213012607800059?focus=true

UI changes

Before changes

Phone Tablet
whats_new_phone_before_changes.mp4 (uploaded via Graphite) whats_new_tablet_before_changes.mp4 (uploaded via Graphite)

|

After changes

Phone Tablet
whats_new_phone.mp4 (uploaded via Graphite) whats_new_tablet_changes.mp4 (uploaded via Graphite)

Note

Improves layout scalability of the “What’s new” modal, especially on tablets.

  • Caps content width via messageContentMaxWidth (600dp) and applies it to header, section title, featured card, and list items
  • Introduces size-specific dimensions (values and values-sw600dp) to adjust margins/padding (e.g., actionButtonHorizontalMargin, featured item spacing)
  • Refactors item layouts to center content within constrained containers (e.g., new listItemContainer in card items; restructured featured card and header wrappers)
  • Updates click handling to use listItemContainer instead of root in CardsListAdapter

Written by Cursor Bugbot for commit c3f50b4. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@catalinradoiu catalinradoiu changed the title Adjust what's new items for tablet Adjust “What's new” modal UI and items for tablet Jan 28, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

<androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
android:paddingBottom="@dimen/featuredListItemBottomMargin">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inner card padding uses wrong dimension resource

Medium Severity

The inner ConstraintLayout's paddingBottom was changed from @dimen/keyline_2 (8dp) to @dimen/featuredListItemBottomMargin. This dimension is meant for spacing between list items (used correctly on the outer wrapper at line 25), not for internal card content padding. On tablets this results in 40dp of internal bottom padding instead of 8dp, creating excessive whitespace inside the featured card. The inner padding likely needs to remain at @dimen/keyline_2.


Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is according to the Figma design.

android:layout_marginStart="@dimen/actionButtonHorizontalMargin"
android:layout_marginEnd="@dimen/actionButtonHorizontalMargin"
android:layout_marginTop="16dp"
android:layout_marginEnd="@dimen/keyline_5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action button missing max width constraint for tablet consistency

Low Severity

The actionButton is missing app:layout_constraintWidth_max="@dimen/messageContentMaxWidth" that was added to all other message components in this PR. On large tablets/foldables (e.g., 1200dp width), the list items above will be constrained to 600dp and centered, while the button stretches to approximately 1080dp, creating visual inconsistency. This appears to be an oversight given the PR's stated goal of adding max width constraints to prevent excessive stretching.


Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is according to the Figma design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants