-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Duck.ai to standalone Activity #5784
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected, just a couple suggestions but nothing blocking.
duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/DuckChatPixels.kt
Outdated
Show resolved
Hide resolved
duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/DuckChatWebViewActivity.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to add this comment
app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt
Outdated
Show resolved
Hide resolved
66dc051
to
14cbad3
Compare
Task/Issue URL: https://app.asana.com/0/488551667048375/1209707104709213/f
Description
WebViewActivity
for the Duck.ai screen.DuckChatWebViewActivity
.Changes
DuckChatWebViewActivity
, with a cut-downWebViewClient
.SubscriptionsWebViewActivity
.WebViewActivity
.DuckChatJsHelper
fromapp
module toduck-chat
module.DuckChatPreferencesStore
intoDuckChatDataStore
.Steps to test this PR
Overflow
SERP
DuckAssist
Shortcut