Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Duck.ai to standalone Activity #5784

Merged
merged 16 commits into from
Mar 20, 2025
Merged

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Mar 17, 2025

Task/Issue URL: https://app.asana.com/0/488551667048375/1209707104709213/f

Description

  • We currently use WebViewActivity for the Duck.ai screen.
  • To fix specific bugs and add specific integrations, this needs to move to it's own Activity: DuckChatWebViewActivity.

Changes

  • Adds DuckChatWebViewActivity, with a cut-down WebViewClient.
    • Hardcodes the UA to the same one used in SubscriptionsWebViewActivity.
  • Removes Duck.ai functionality from WebViewActivity.
  • Moves DuckChatJsHelper from app module to duck-chat module.
  • Integrates DuckChatPreferencesStore into DuckChatDataStore.

Steps to test this PR

Overflow

  • Open Duck.ai from the overflow
  • Verify that Duck.ai is opened

SERP

  • Search for something
  • Open Duck.ai using the SERP button
  • Verify that Duck.ai is opened (With pre-filled text)

DuckAssist

  • Search for “how tall is a giraffe"
  • Click the “Chat" button from DuckAssist
  • Verify that Duck.ai is opened (And DuckAssist is triggered)

Shortcut

  • Open Duck.ai form the shortcut
  • Verify that Duck.ai is opened

Sorry, something went wrong.

Copy link
Contributor Author

joshliebe commented Mar 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joshliebe joshliebe mentioned this pull request Mar 18, 2025
3 tasks
@joshliebe joshliebe mentioned this pull request Mar 19, 2025
6 tasks
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected, just a couple suggestions but nothing blocking.

Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to add this comment

@joshliebe joshliebe force-pushed the feature/josh/duck-ai-standalone branch from 66dc051 to 14cbad3 Compare March 20, 2025 00:10
@joshliebe joshliebe merged commit 1db0951 into develop Mar 20, 2025
6 checks passed
@joshliebe joshliebe deleted the feature/josh/duck-ai-standalone branch March 20, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants