Duck Player custom error #5698
Open
Duck Player custom error #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgurgel
force-pushed
the
feature/mgurgel/duckplayer-custom-error
branch
2 times, most recently
from
13f1ebd to
9d36ba9
Compare
CrisBarreiro
requested changes
Mar 4, 2025
app/src/main/java/com/duckduckgo/app/browser/duckplayer/DuckPlayerJSHelper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/duckplayer/DuckPlayerJSHelper.kt
Outdated
Show resolved
Hide resolved
duckplayer/duckplayer-api/src/main/java/com/duckduckgo/duckplayer/api/DuckPlayer.kt
Outdated
Show resolved
Hide resolved
duckplayer/duckplayer-impl/src/main/java/com/duckduckgo/duckplayer/impl/DuckPlayerPixelName.kt
Outdated
Show resolved
Hide resolved
mgurgel
force-pushed
the
feature/mgurgel/duckplayer-custom-error
branch
from
9d36ba9 to
e765ca6
Compare
|
@CrisBarreiro I've addressed the nits, but I'll reach out tomorrow for clarification on the bigger RC issue. Thanks so much and sorry for the delay. |
mgurgel
force-pushed
the
feature/mgurgel/duckplayer-custom-error
branch
from
e765ca6 to
bc3bffa
Compare
mgurgel
commented
Mar 12, 2025
duckplayer/duckplayer-impl/src/main/java/com/duckduckgo/duckplayer/CustomErrorPagePlugin.kt
Show resolved
Hide resolved
CrisBarreiro
requested changes
Mar 13, 2025
duckplayer/duckplayer-impl/src/main/java/com/duckduckgo/duckplayer/CustomErrorPagePlugin.kt
Show resolved
Hide resolved
duckplayer/duckplayer-impl/src/main/java/com/duckduckgo/duckplayer/impl/DuckPlayerFeature.kt
Outdated
Show resolved
Hide resolved
CrisBarreiro
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209459625347014
Description
Shows a custom error screen when Duck Player detects an error message in the YouTube embed
Steps to test this PR
npm i github:duckduckgo/content-scope-scripts.git#d9ee95a36cf046e1678d2786742a67b986af6cbfUI changes