Skip onboarding in most maestro tests

[CDRussell]

Task/Issue URL: https://app.asana.com/0/608920331025315/1209483465015032

Description

Steps to test this PR

Check these workflows finished successfully:

• Autofill Feature Critical Path End-to-End test
• Custom Tabs nightly tests
• Android Design System End-to-End tests
• End-to-End tests (Robin)
• Privacy Dashboard End-to-End tests

[CDRussell]

• Skip onboarding in most maestro tests #5682 👈 (View in Graphite)
• Support skipping onboarding with build flag or for internal builds #5681
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR updates Maestro test flows to skip the onboarding process in most tests. The key changes are:

• Replacing references to pre_onboarding.yaml with skip_all_onboarding.yaml across multiple test files.
• Updating maxRetries from 3 to 0 and adding an ambiguous tag in one test file.

Reviewed Changes

Copilot reviewed 69 out of 69 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
.maestro/autofill/1_autofill_shown_in_overflow.yaml	Updated tag, maxRetries, and onboarding flow to skip_all_onboarding.yaml.
.maestro/autofill/backfillingUsername/multi_step_login_username_backfilled.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ads_preview_flows/1-_design-system-components.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/autofill/3_autofill_prompted_to_save_creds_on_form.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/app_tp/app_tp_onboarding.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/autofill/2_autofill_add_search_update_delete_creds.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/5_-_y.js_heuristic_ad_domain_provided,_but_empty_u3_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/2_-_m.js_heuristic_no_ad_domain_param_dsl_param_included_1_1.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/8_-_m.js_bing-provided_ad_domain_provided_dsl_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/10_-_m.js_bing-provided_ad_domain_provided_but_incorrect_dsl_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/11_-_y.js_bing-provided_ad_domain_provided_but_it's_not_a_domain_i.e.,_abcedf_u3_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/12_-_m.js_bing-provided_ad_domain_provided_but_it's_not_a_domain_i.e.,_abcedf__dsl_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/14_-_m.js_bing-provided_ad_domain_provided_but_it's_a_subdomain_of_advertiser_i.e.,_foo.www.search-company-site__dsl_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/4_-_m.js_heuristic_no_ad_domain_param,_but_missing_dsl_param_1_1.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/13_-_y.js_bing-provided_ad_domain_provided_but_it's_a_subdomain_of_advertiser_i.e.,_foo.www.search-company-site_u3_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/9_-_y.js_bing-provided_ad_domain_provided_but_incorrect_u3_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/6_-_m.js_heuristic_ad_domain_provided,_but_empty_dsl_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/1_-_y.js_heuristic_no_ad_domain_param_u3_param_included_1_1_1.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/3_-_y.js_heuristic_no_ad_domain_param,_but_missing_u3_param_1_1.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.
.maestro/ad_click_detection_flows/7_-_y.js_bing-provided_ad_domain_provided_u3_not_needed.yaml	Replaced pre_onboarding with skip_all_onboarding.yaml.

Comments suppressed due to low confidence (2)

.maestro/autofill/1_autofill_shown_in_overflow.yaml:5

• [nitpick] The tag 'x' appears ambiguous; consider using a more descriptive tag name or removing it if unintentional.

    - x

.maestro/autofill/1_autofill_shown_in_overflow.yaml:10

• Changing maxRetries from 3 to 0 disables the retry mechanism, which could lead to test failures in case of intermittent issues; confirm if this is intentional.

maxRetries: 0

[Copilot]

Pull Request Overview

This PR updates Maestro test flows to bypass the onboarding process across various YAML configurations and Gradle workflows.

• Replaces the pre_onboarding runFlow with skip_all_onboarding in multiple ad detection and app flows.
• Adds the -Pskip-onboarding flag to Gradle assemble commands in GitHub workflows.

Reviewed Changes

Copilot reviewed 67 out of 67 changed files in this pull request and generated no comments.

File	Description
.maestro/ad_click_detection_flows/*	Replaces pre_onboarding with skip_all_onboarding in various test flows.
.maestro/app_tp/app_tp_onboarding.yaml	Updates onboarding flow from pre_onboarding to skip_all_onboarding.
.maestro/ads_preview_flows/1-_design-system-components.yaml	Replaces pre_onboarding with skip_all_onboarding.
.github/workflows/privacy-dashboard-end-to-end.yml, release_tests.yml, end-to-end-robintest.yml, e2e-nightly-autofill.yml	Adds the -Pskip-onboarding flag to Gradle commands.

[CDRussell]

slightly awkward, but this is a mechanism to choose to skip onboarding if possible, and if the button doesn’t appear (unexpectedly) then the test can complete the full onboarding manually

[CrisBarreiro]

why are we changing the tag?

[CDRussell]

This test doesn’t require no auth flag to be provided, it’s a general smoke test that will always work on any device config (and if it doesn’t, we want a strong signal) so adding it as part of the general release tests.