Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-selection: Tab switcher #5464

Open
wants to merge 80 commits into
base: develop
Choose a base branch
from

Conversation

0nko
Copy link
Member

@0nko 0nko commented Jan 14, 2025

Task/Issue URL: https://app.asana.com/0/1207418217763355/1209148925370449/f

Description

This PR is the feature branch for the tab switcher multi-selection project.

Steps to test this PR

Nothing to test, this will serve as a feature branch.

Copy link
Member Author

0nko commented Jan 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0nko 0nko added the QA-Optional label Jan 14, 2025 — with Graphite App
@0nko 0nko marked this pull request as ready for review January 14, 2025 11:07
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from 42e94eb to 0d73e35 Compare January 14, 2025 11:09
@0nko 0nko changed the title Add a new feature flag for multi-selection Multi-selection: Add a new feature flag for multi-selection Jan 14, 2025
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from 0b382b2 to 8492b52 Compare January 15, 2025 17:28
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from 8492b52 to c4c3cf8 Compare January 27, 2025 10:12
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch 2 times, most recently from c3270a9 to e6e2148 Compare January 31, 2025 15:26
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from e6e2148 to ff15dd9 Compare February 3, 2025 20:20
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from ff15dd9 to 02fb482 Compare February 13, 2025 10:54
@0nko 0nko requested review from mikescamell and removed request for malmstein and nalcalag February 13, 2025 10:58
@mikescamell mikescamell self-assigned this Feb 13, 2025
Comment on lines 39 to 36
@ContributesMultibinding(
scope = AppScope::class,
boundType = ApiInterceptorPlugin::class,
)
class BlockListInterceptorApiPlugin @Inject constructor(
class BlockListInterceptorApiPlugin constructor(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why was this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems like this was added with a rebase.

Copy link
Contributor

@mikescamell mikescamell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good apart from that BlockListInterceptorApiPlugin change 👍

@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch 2 times, most recently from eab74f4 to 3d62cf6 Compare February 14, 2025 14:01
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from 3d62cf6 to 01126c4 Compare February 27, 2025 17:15
@0nko 0nko mentioned this pull request Feb 27, 2025
19 tasks
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from 01126c4 to b38ddf4 Compare February 28, 2025 17:43
@0nko 0nko mentioned this pull request Feb 28, 2025
32 tasks
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch 2 times, most recently from cca1829 to da3cae9 Compare March 3, 2025 20:28
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from 57d8234 to 1b96287 Compare March 19, 2025 22:18
@0nko 0nko mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants