Update pixels in onboarding experiment #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CrisBarreiro
approved these changes
May 27, 2024
cmonfortep
pushed a commit
that referenced
this pull request
May 27, 2024
Task/Issue URL: https://app.asana.com/0/1201807753394693/1207407312592951/f ### Description Add three unique pixels when pre-onboarding dialogs are shown ### Steps to test this PR _Pre steps_ - [x] Make `fun isComparisonChartEnabled(): Boolean` return always `true` in `ExtendedOnboardingExperimentVariantManagerImpl` _Feature 1_ - [x] Fresh install - [x] When first dialog is displayed, check `m_preonboarding_intro_shown_unique` is fired - [x] When comparison chart is displayed, check `m_preonboarding_comparison_chart_shown_unique` is fired - [x] Set DDG as default browser - [x] When affirmation dialog is displayed, check `m_preonboarding_affirmation_shown_unique` is fired ### No UI changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201807753394693/1207407312592951/f
Description
Add three unique pixels when pre-onboarding dialogs are shown
Steps to test this PR
Pre steps
fun isComparisonChartEnabled(): Booleanreturn alwaystrueinExtendedOnboardingExperimentVariantManagerImplFeature 1
m_preonboarding_intro_shown_uniqueis firedm_preonboarding_comparison_chart_shown_uniqueis firedm_preonboarding_affirmation_shown_uniqueis firedNo UI changes