Release Extended Onboarding to all users #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
nalcalag
force-pushed
the
feature/noelia/extented_onboarding_to_all_users
branch
3 times, most recently
from
93bcae0
to
b540737
Compare
anikiki
reviewed
May 30, 2024
| @@ -453,7 +447,7 @@ open class BrowserActivity : DuckDuckGoActivity() { | |||
| } | |||
| dialog.setOnShowListener { currentTab?.onFireDialogVisibilityChanged(isVisible = true) } | |||
| dialog.setOnCancelListener { | |||
| pixel.fire(if (dialog.ctaVisible) FIRE_DIALOG_PROMOTED_CANCEL else FIRE_DIALOG_CANCEL) | |||
There was a problem hiding this comment.
Do we still need to keep the FIRE_DIALOG_PROMOTED_CANCEL constant in the code? I see it's not used anymore.
There was a problem hiding this comment.
Good catch! I'll remove it
…ureToggles for the CTAs
anikiki
approved these changes
May 30, 2024
nalcalag
force-pushed
the
feature/noelia/extented_onboarding_to_all_users
branch
2 times, most recently
from
213ce68
to
4298307
Compare
nalcalag
force-pushed
the
feature/noelia/extented_onboarding_to_all_users
branch
from
4298307
to
126c541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201807753394693/1207407312592960/f
Description
Remove old onboarding and release new extended onboarding to all users
Steps to test this PR
Pre onboarding
Search suggestions dialog
SERP Dax dialog
Site suggestions Dax dialog
Got it!buttonSurprise me!optionbritannica.com/animal/duck...
Trackers Blocked Dax dialog
Got it!button...
Fire Button Dax dialog
...
End onboarding dialog
...
No Trackers Dax dialog
wikipedia.org...
Trackers Network Dax dialog
instagram.comUI changes
extended_onboarding_flow.1.mp4