Improve SQLGetInfo for MS Access #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticlibs
changed the title
staticlibs
force-pushed
the
access_sqlgetinfo_len
branch
from
649fadb to
4839bb4
Compare
The ODBC client used in MS Access (also known as Microsoft Jet) has specific requirements to the `SQLGetInfo` driver function. First, it requires `SQL_ODBC_API_CONFORMANCE` to be supported. Second, it requires the output parameter `StringLengthPtr` to be set by driver even when the `InfoValuePtr` is set to non-character (integer) value. Otherwise it fails with `Reserved error (-7701);` message and disconnects immediately after the successfull connection. This change adds a new helper `StoreWithLength` and applies it to all non-character usages in `SQLGetInfo` and in `SQLGetConnectAttr` functions. With it MS Access can establish the connection and start running SQL queries. Though, it still fails on schema introspectio (more Jet-specific fixes are needed in driver), so duckdb#39 remains open for now. Testing: length check for non-character data is added to the existing test.
staticlibs
force-pushed
the
access_sqlgetinfo_len
branch
from
4839bb4 to
3044dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ODBC client used in MS Access (also known as Microsoft Jet) has specific requirements to the
SQLGetInfodriver function. First, it requiresSQL_ODBC_API_CONFORMANCEto be supported. Second, it requires the output parameterStringLengthPtrto be set by driver even when theInfoValuePtris set to non-character (integer) value. Otherwise it fails withReserved error (-7701);message and disconnects immediately after the successfull connection.This change adds a new helper
StoreWithLengthand applies it to all non-character usages inSQLGetInfoand inSQLGetConnectAttrfunctions. With it MS Access can establish the connection and start running SQL queries. Though, it still fails on schema introspectio (more Jet-specific fixes are needed in driver), so #39 remains open for now.Testing: length check for non-character data is added to the existing test.