Fix SQLGetDiagRec for length-only calls #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to ODBC spec: > If `MessageText` is `NULL`, `TextLengthPtr` will still return the > total number of characters (excluding the null-termination character > for character data) available to return in the buffer pointed to by > `MessageText`. Such length-only calls are actually used by the Windows ODBC Driver Manager. Currently messages are returned in garbled form on Windows. This change adds the logic to set the `TextLengthPtr` to the actual message length when the `MessageText` is specified as `NULL`. Note: the impl still can be improved to handle partial message reads better (cover existing TODO there). Testing: existing test is extended to cover this scenario. Fixes: duckdb#56
staticlibs
force-pushed
the
get_diag_rec_len
branch
from
4f56ca2 to
87692be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to ODBC spec:
Such length-only calls are actually used by the Windows ODBC Driver Manager. Currently messages are returned in garbled form on Windows.
This change adds the logic to set the
TextLengthPtrto the actual message length when theMessageTextis specified asNULL.Note: the impl still can be improved to handle partial message reads better (cover existing TODO there).
Testing: existing test is extended to cover this scenario.
Fixes: #56