Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Drop method nextArrayInt from Random #5679

Merged
merged 2 commits into from
Feb 7, 2025
Merged

💥 Drop method nextArrayInt from Random #5679

merged 2 commits into from
Feb 7, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Feb 7, 2025

Description

The method nextArrayInt has initially be introduced on our instances of Random in order to ease the implementation of our arbitrary double. When introduced the type bigint was not really supported and thus we had to use something else. Now that this type is available, we can drop this legacy helper.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: 💥 Breaking change
  • Impacts: Dropping one method from random, maybe affect users manually writing their own arbitraries

Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 40b569d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Feb 7, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5679

fast-check

npm i https://pkg.pr.new/fast-check@5679

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5679

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5679

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5679

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5679

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5679

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5679

commit: 40b569d

@dubzzz dubzzz enabled auto-merge (squash) February 7, 2025 00:54
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 A preview of the new documentation is available at: http://67a559da5c6163aaa0fc4288--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (8a09008) to head (40b569d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5679      +/-   ##
==========================================
+ Coverage   94.43%   94.48%   +0.04%     
==========================================
  Files         212      212              
  Lines        9619     9613       -6     
  Branches     2664     2664              
==========================================
- Hits         9084     9083       -1     
+ Misses        535      530       -5     
Flag Coverage Δ
unit-tests 94.48% <ø> (+0.04%) ⬆️
unit-tests-18.x-Linux 94.48% <ø> (+0.04%) ⬆️
unit-tests-20.x-Linux 94.48% <ø> (+0.10%) ⬆️
unit-tests-22.x-Linux 94.48% <ø> (+0.04%) ⬆️
unit-tests-latest-Linux 94.48% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 41a6b51 into main Feb 7, 2025
56 checks passed
@dubzzz dubzzz deleted the drop-nextarrayint branch February 7, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant