Refactor Hessian update #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.4.3 #337 +/- ##
==========================================
+ Coverage 97.38% 97.39% +0.01%
==========================================
Files 200 200
Lines 23064 23062 -2
==========================================
+ Hits 22461 22462 +1
+ Misses 603 600 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@t-young31 Hi, do you know why the macOS jobs are failing even without starting tests? I did not change anything in the github builds directory |
|
looks like conda-incubator/setup-miniconda#344 |
t-young31
reviewed
May 3, 2024
|
@t-young31 I found a bug and included the fix in this PR, could you please have another look before merge? |
t-young31
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts the hessian update into the coordinate object. This is for consistency with the
update_h_from_cart_hmethod and for future modification of the optimiser loop.Checklist