Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1058: add MediaContainerResourceTest & more #1059

Merged
merged 3 commits into from
Apr 18, 2022
Merged

fixes #1058: add MediaContainerResourceTest & more #1059

merged 3 commits into from
Apr 18, 2022

Commits on Apr 15, 2022

  1. fixes dtinit#1058: add MediaContainerResourceTest & more 

    adds MediaContainerResourceTest and fixes bug said test newly reveals in
automatic root album creation logic during transmogrification.

nit: in nit-fixing doc bug (documentation was wrong on
`MediaContainerResource#ensureRootAlbum`) also just lifts conditional
logic being pushed down into helper function; taking liberty here with
my opinion - that Single Responsibility (SOLID) would remove this
complexity to begin with (`ensureRootAlbum` should not care about what a
transmogrification is or what its config is).
    @jzacsh
    jzacsh committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    ddd111b View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2022

  1. noop(nit:docs): point TODO at a trackable issue number

    @jzacsh
    jzacsh committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    2a1cb3d View commit details
    Browse the repository at this point in the history

  2. noop(readability) run Goog style via clang-format

    @jzacsh
    jzacsh committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    3e728b2 View commit details
    Browse the repository at this point in the history