Merge pull request #30 from dsl-builders/chore/dispose-streaming-work…

…book calling dispose on streaming worksheet
dsl-builders · Jan 9, 2025 · 9b3fc7c · 9b3fc7c
2 parents acefd07 + 6ab28ff
commit 9b3fc7c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -12,11 +12,11 @@ jobs:
       GRADLE_OPTS: "-Xmx6g -Xms4g"
       LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}
     steps:
-      - uses: actions/checkout@v1
-      - name: Set up JDK 1.8
-        uses: actions/setup-java@v1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-java@v3
         with:
-          java-version: 1.8
+          distribution: zulu
+          java-version: 17
       - name: Decrypt Stored Credentials
         run: ./libs/spreadsheet-builder-google/tokens/decrypt_secret.sh
       - name: Decode PGP
@@ -28,7 +28,7 @@ jobs:
       - name: Semantic Version
         id: version
         uses: ncipollo/semantic-version-action@v1
-      - uses: eskatos/gradle-command-action@v2
+      - uses: gradle/gradle-command-action@v2
         env:
           SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
           SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}

diff --git a/...builder-poi/src/main/java/builders/dsl/spreadsheet/builder/poi/PoiSpreadsheetBuilder.java b/...builder-poi/src/main/java/builders/dsl/spreadsheet/builder/poi/PoiSpreadsheetBuilder.java
@@ -117,6 +117,10 @@ public void build(Consumer<WorkbookDefinition> workbookDefinition) {
             if (closeWorkbook && workbook != null) {
                 try {
                     workbook.close();
+                    if (workbook instanceof SXSSFWorkbook) {
+                        SXSSFWorkbook sxssfWorkbook = (SXSSFWorkbook) workbook;
+                        sxssfWorkbook.dispose();
+                    }
                 } catch (IOException e) {
                     System.getLogger(PoiSpreadsheetBuilder.class.getName()).log(System.Logger.Level.ERROR, "Exception closing workbook", e);
                 }