Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xWebAdministration: Moved PHP example from README.md into its own example file #539

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vikingtiger
Copy link

@vikingtiger vikingtiger commented Oct 22, 2019

Pull Request (PR) description

The PHP example was moved from README.md into its own example file under the /Examples directory.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

Now reflects that the PHP sample was moved away from README.md into its
own .ps1 script file under examples directory.
@msftclas
Copy link

msftclas commented Oct 22, 2019

CLA assistant check
All CLA requirements met.

@johlju johlju added the needs review The pull request needs a code review. label Oct 23, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov-io
Copy link

Codecov Report

Merging #539 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #539   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          17       17           
  Lines        2766     2766           
=======================================
  Hits         2537     2537           
  Misses        229      229
Impacted Files Coverage Δ
DSCResources/MSFT_xWebSite/MSFT_xWebSite.psm1
DSCResources/MSFT_xWebsite/MSFT_xWebsite.psm1 97.22% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d5227...35750ac. Read the comment docs.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR didn't pass the tests. Please resolve the issue.

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vikingtiger)


Examples/Resources/Sample_EndToEnd_RegisterPhp.ps1, line 91 at r2 (raw file):

xRemoteFile phpArchive

Please see failing test https://ci.appveyor.com/project/PowerShell/xwebadministration/builds/28331735?fullLog=true#L965

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. invalid Used for PR's to tell hacktoberfest that the PR should not count and removed needs review The pull request needs a code review. labels Oct 24, 2019
@johlju johlju changed the base branch from dev to master December 30, 2019 12:15
@johlju johlju changed the base branch from master to main January 7, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Used for PR's to tell hacktoberfest that the PR should not count waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xWebAdministration: Move example from README.md to examples folder
4 participants