-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xWebAdministration: Moved PHP example from README.md into its own example file #539
base: main
Are you sure you want to change the base?
Conversation
Now reflects that the PHP sample was moved away from README.md into its own .ps1 script file under examples directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## dev #539 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 17 17
Lines 2766 2766
=======================================
Hits 2537 2537
Misses 229 229
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR didn't pass the tests. Please resolve the issue.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vikingtiger)
Examples/Resources/Sample_EndToEnd_RegisterPhp.ps1, line 91 at r2 (raw file):
xRemoteFile phpArchive
Please see failing test https://ci.appveyor.com/project/PowerShell/xwebadministration/builds/28331735?fullLog=true#L965
Pull Request (PR) description
The PHP example was moved from README.md into its own example file under the
/Examples
directory.This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
and comment-based help.
This change is