-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements trace
for failures
#422
Implements trace
for failures
#422
Conversation
077a040
to
398e284
Compare
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 48 +1
Lines 1192 1221 +29
Branches 154 154
=========================================
+ Hits 1192 1221 +29
Continue to review full report at Codecov.
|
Should I have add something to |
…thod signature from "_Failure" class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Some polishing is required and we are ready to go!
2bff2fe
to
2bf6aec
Compare
9bf1b19
to
0039a20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I also got an idea that we should add an opportunity to test traces with out pytest
plugins.
This should help people to predict which paths the code will take.
But, I am not sure about an API. Do you have any ideas?
I didn't understand your idea, sorry! |
I will create a new issue for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like almost done!
I am pretty sure that this is the last round of review and we are going to merge this soon.
You have my gratitude, thanks a lot! 🥇
Thanks man, it's a pleasure to contribute to |
Thanks again! P.S. Can you please take a look at #258? I am researching possible design ideas right now. I would love to hear your thoughts. |
Yes, I'll take a look asap! |
All context can be found on #409 issue!
Just a little explanation about
_get_trace
function:The return is the current call stack starting from the third position, to avoid two non useful calls on the call stack and you can see in the example below what calls they're:
Complete call stack
call stack starting from third position
closes #409