teach xsd.Schema how to merge type maps #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a new MergeTypes method is added to the xsd.Schema type which merges the types from one xsd.Schema into another provided that the TargetNS values are equivalent. this MergeTypes method is then used when collecting the map of namespaces to schemas so that when a single schema is spread across multiple files (e.g. when imports are used to tie them together) the types from a namespace are all collected together, regardless of which files they came from. this allows the resolvePartialTypes method to operate as expected, since following the imports will now merge the types into a single xsd.Schema.
previously when a single target namespace was spread across multiple files, the last schema file read for each target namespace would clobber any previously read type maps this commit adds some minimal target namespace collision detection and delegates to the xsd.Schema class the responsibility to resolve that conflict.
droyo
reviewed
Mar 13, 2021
| // the receiving schema, returns error if the schemas have | ||
| // different target namespaces. | ||
| func (s *Schema) MergeTypes(incoming *Schema) error { | ||
| if !strings.EqualFold(s.TargetNS, incoming.TargetNS) { |
There was a problem hiding this comment.
I was under the impression that XML namespaces are case sensitive. What is the reason for using EqualFold over == here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a new MergeTypes method is added to the xsd.Schema type
which merges the types from one xsd.Schema into another
provided that the TargetNS values are equivalent.
this MergeTypes method is then used when collecting
the map of namespaces to schemas so that when a single
schema is spread across multiple files (e.g. when
imports are used to tie them together) the types from
a namespace are all collected together, regardless of
which files they came from.
this allows the resolvePartialTypes method to operate
as expected, since following the imports will now
merge the types into a single xsd.Schema.