Draft: [Pg] Add support for procedural functions #4753
+714
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, this PR is my attempt at adding support for postgres functions to Drizzle.
Syntax:
While I did add some tests (basically only in drizzle-kit), I'm not 100% confident to have covered everything since this repo is quite big, so I'd ask for some review by the maintainers before proceeding further (that's why I'm marking this as draft). Right now it's possible to define functions, introspect functions and generate migrations from the schema snapshot. Every time a function changes, it will be dropped and recreated (to keep things simpler instead of ALTER-ing it).
Right now, not all function parameters are supported, but they should be easily added if the proposed approach works.
This PR also forces singlestore to use
linux/amd64
image since it's not available on arm and tests were failing then.Related issues/discussions:
#2586
#2434