[MySQL]: optimize result set streaming from iterator()
#4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reecefenwick
changed the title
.iterator().iterator()
reecefenwick
changed the title
.iterator()iterator()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the iterator I found it doesn't perform as well as I was expecting with really large datasets (1 million+ rows) based on past experiences with streams from
mysql2I've simplified the implementation to just use
for await, it's functionally equivalent in terms of control flow and error handling, but consumes less resources in the process since we are allocating far less inside the loop.A before and after streaming 1 million rows
Before: 22 Seconds
After: 8 seconds