Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new check if the space already exists #286

Merged

Conversation

howareyouman
Copy link
Contributor

@howareyouman howareyouman commented Mar 17, 2025

Summary

Adding check if catalog/space already exists. It will unblock non-admin users in DC from starting to use dbt-dremio.

Description

Before only ADMIN users of DC were able to run dbt-dremio. Now we are checking if the catalog exists and it unblocks customers to use non-admin users in DC with dbt-dremio.

Test Results

Created a tech dept ticket to create dbt-dremio tests for it. Run only manual tests with DC instance.

Changelog

  • Added a summary of what this PR accomplishes to CHANGELOG.md

Sorry, something went wrong.

@howareyouman howareyouman marked this pull request as ready for review March 19, 2025 10:13
simonpannek
simonpannek previously approved these changes Mar 19, 2025
Copy link
Contributor

@bcmeireles bcmeireles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess merging without tests will be OK for now as we don't have the DC pipelines but we should keep in mind to come back to this once we have them

@howareyouman howareyouman merged commit 0fe3d3c into dremio:main Mar 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants