bugfix: stat s3 common prefix #2100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Numblgw
force-pushed
the
bugfix_stat_s3_common_prefix
branch
from
31a4765 to
462e28d
Compare
Owner
|
Hello, thanks for the PR. I assume this change is meant to improve compatibility with implementations like SeaweedFS. If SeaweedFS (or your target implementation) behaves like S3 when directory buckets are enabled, it will be supported automatically. Otherwise, it’s the external implementation’s responsibility to align with S3 behavior. In the long term, we’d like to remove workarounds such as this altogether. |
Owner
|
Please refer to the following documentation if you are using SeaweedFS. Otherwise, please provide more details about your S3 implementation. https://github.com/seaweedfs/seaweedfs/wiki/Amazon-S3-API#empty-folders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for Pull Requests
Description
Directories automatically created via the S3 protocol are returned as common prefixes during list queries. However, some S3 implementations do not support HEAD requests for common prefixes, and empty common prefixes are not automatically removed when objects are deleted. In such cases, when performing a stat operation, both the headObject and getStatForDir functions will return errors, making it necessary to rely on the hasContents function to correctly identify directories (common prefixes). However, when a directory (common prefix) contains only subdirectories (also common prefixes) and no objects, this function fails to work correctly. As a result, the directory (common prefix) cannot be properly removed (rm) or accessed (cd).