Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

bug fix dfget client timeout set error when fileLength is 0 #1032

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

ww3122000
Copy link

Ⅰ. Describe what this PR did

bug fix dfget client timeout set error when fileLength is 0

Ⅱ. Does this pull request fix one issue?

bug fix dfget client timeout set error when fileLength is 0

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

use dfget and set timeout

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Oct 28, 2019
@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Dragonfly, @ww3122000
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@allencloud
Copy link
Contributor

Thanks for your contribution, Please help to sign https://github.com/dragonflyoss/Dragonfly/pull/1032/checks?check_run_id=277021510. @ww3122000

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #1032 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
- Coverage   46.64%   46.62%   -0.02%     
==========================================
  Files         115      115              
  Lines        7002     7002              
==========================================
- Hits         3266     3265       -1     
  Misses       3481     3481              
- Partials      255      256       +1
Impacted Files Coverage Δ
dfget/core/core.go 45.83% <0%> (ø) ⬆️
supernode/daemon/mgr/scheduler/manager.go 21.91% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd6fbb...a595663. Read the comment docs.

@allencloud
Copy link
Contributor

In addition, if you need to real-time chatting, please see #291 to join us.

@allencloud
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 28, 2019
@starnop
Copy link
Contributor

starnop commented Oct 28, 2019

LGTM.

@starnop starnop merged commit d6666ea into dragonflyoss:master Oct 28, 2019
starnop added a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
bug fix dfget client timeout set error when fileLength is 0
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
bug fix dfget client timeout set error when fileLength is 0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants