Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dracut-install): handle correctly sysrootdir with trailing '/' #2667

Closed
wants to merge 1 commit into from
Closed

fix(dracut-install): handle correctly sysrootdir with trailing '/' #2667

wants to merge 1 commit into from

Conversation

kubiko
Copy link

@kubiko kubiko commented Jul 26, 2024

This pull request fixes incorrect handling of --sysrootdir argument when passed value trails with /

Changes

check passed sysrootdir for trailing / and decrement sysrootdirlen by 1 if / is detected.

Checklist

  • [ x] I have tested it locally
  • [x ] I have reviewed and updated any documentation if relevant
  • [ x] I am providing new code and test(s) for it

Fixes #
#2666

@github-actions github-actions bot added the dracut-install Issues related to dracut install label Jul 26, 2024
@kubiko
Copy link
Author

kubiko commented Jul 26, 2024

Looks like wrong project

@kubiko kubiko closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haraldh haraldh Awaiting requested review from haraldh haraldh is a code owner

@johannbg johannbg Awaiting requested review from johannbg johannbg is a code owner

Assignees
No one assigned
Labels
dracut-install Issues related to dracut install
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kubiko