fix(systemd): explicitly install some libs that will not be statically included #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
systemd
aafeijoo-suse
force-pushed
the
systemd-dlopen-fix
branch
from
f08beef
to
75820de
Compare
aafeijoo-suse
changed the title
ddiss
approved these changes
Apr 2, 2024
ddiss
reviewed
Apr 2, 2024
| {"tls/$_arch/",tls/,"$_arch/",}"libzstd.so.*" \ | ||
| {"tls/$_arch/",tls/,"$_arch/",}"liblzma.so.*" | ||
| {"tls/$_arch/",tls/,"$_arch/",}"liblzma.so.*" \ | ||
| {"tls/$_arch/",tls/,"$_arch/",}"libzstd.so.*" |
There was a problem hiding this comment.
Could $hostonly images selectively drop some of these modules, depending on systemd-journal configuration?
There was a problem hiding this comment.
I know the default compression is configured at build time, but it can also be set via SYSTEMD_JOURNAL_COMPRESS env var... I'll take a look
Thanks, that's what I was thinking. I'll remove the draft mark and amend the commit message including those external references if they are merged. |
aafeijoo-suse
force-pushed
the
systemd-dlopen-fix
branch
from
75820de
to
b802845
Compare
…y included Some required libraries that used to be statically included are in the process to be opened via `dlopen()`. References: - systemd/systemd#31131 - systemd/systemd#31550 - systemd/systemd#32019 Closes dracutdevs#2642
aafeijoo-suse
force-pushed
the
systemd-dlopen-fix
branch
from
b802845
to
5b4466e
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some required libraries that used to be statically included are in the process to be opened via
dlopen().Checklist
Closes #2642