Skip to content

Fix DQ_CoppeliaSimRobotZMQ class and its derived robots #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ffasilva
Copy link
Member

Hi @juanjqo,

The class DQ_CoppeliaSimRobotZMQ had broken references to the DQ_CoppeliaSimInterfaceZMQExperimental class. I fixed them and the references that were also broken on the robots derived from it (FrankaEmikaPandaCoppeliaSimZMQRobot and URXCoppeliaSimZMQRobot).

I just did some preliminary tests on the URXCoppeliaSimZMQRobot, as I'll mostly be inheriting from DQ_CoppeliaSimRobotZMQ to add the dynamic properties, but everything seems to be working now.

Kind regards,
Frederico

@juanjqo
Copy link
Member

juanjqo commented Feb 24, 2025

Hi @ffasilva,

Thank you for the report. The classes DQ_CoppeliaSimRobot, DQ_CoppeliaSimRobotZMQ, and DQ_CoppeliaSimZmqRobot require modifications to follow the current strategy we adopted concerning a stable and experimental class of the ZMQ interface. In other words, the class DQ_CoppeliaSimRobotZMQ must use the class DQ_CoppeliaSimInterfaceZMQ but not their experimental version. In the last case, we could add a class DQ_CoppeliaSimRobotZMQExperimental.

In summary, we need to remove in a future PR the classes DQ_CoppeliaSimRobot, DQ_CoppeliaSimRobotZMQ, and DQ_CoppeliaSimZmqRobot temporarily.

Kind regards,

Juancho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants