Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check client version iif not given #2048

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacopofar
Copy link

@jacopofar jacopofar commented May 12, 2020

The docstring states the api_version and api_version_auto_timeout_ms are used to decide if check_version() has to be called and for how long it has to wait, now the function follows that behavior, consistent with the KafkaClient

This could help with problems like #1308


This change is Reviewable

The docstring states the `api_version` and `api_version_auto_timeout_ms` are used to decide if check_version() has to be called and for how long it has to wait, now the function follows that behavior, consistent with the `KafkaClient`
@jacopofar
Copy link
Author

jacopofar commented May 12, 2020

I found later that this behavior was introduced in #1953 because if check_version() is not called calls to get_api_versions() will fail.

Could it make sense then to remove the api_version parameter which is not used and pass the api_version_auto_timeout_ms timeout to it?

@jeffwidman
Copy link
Contributor

Possibly related #2107 / #2108 ... as I noted #2108 (review), we should probably step-back and re-examine the way this gets handled so that it's consistent everywhere.

@dpkp dpkp force-pushed the master branch 2 times, most recently from 9c8c8af to 8ebb14c Compare February 12, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants