-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More verbosity on exceptions #1838
base: master
Are you sure you want to change the base?
Conversation
@dpkp / @tvoinarovskyi your thoughts here? Some of these look useful, some not so much (ie, I'd be hesitant to replace the |
@jeffwidman the only |
I feel like having tracebacks on those errors are not too useful. Logs are quite unique and you can find the point it fails on relatively easy. In logging, you can format the log to include the source line without the need to print tracebacks. As for replacing the "pass", it seems like the case is critical and should not be triggered in a normal workflow, so printing that exception actually may help. I'm ok with adding it. Although the message might be something more descriptive: "In-flight requests remain on a close connection. Socket error:" |
@tvoinarovskyi thanks for your response. My original idea was to get that stacktrace to understand where it fails whenever it happens and, more importantly, where it retries without appropriate error management (please see #1837). Concerning the "pass", not being part of the normal workflow could be a good reason to log it, as it should not happen so frequently. It may be the case that a normal user could understand the root cause of such error messages and fix it (closed ports, firewalls that screw up the the network traffic, persistent connections killed by external actors...). The additional descriptive message could help. Does it fail for the fact that "In-flight requests remain on a close connection"? Or there are other cases? If so, do we have, at that level, enough information do be more descriptive? I am new with this project, so I do not know, but that stacktrace could help me much about the nature of such errors. :-) |
How about adding an optional configuration parameter that would enable |
@fcracker79 care to rebase? Note that due to #1193 the codebase shed a lot of old deprecated code, so that may slim this down a bit as well... |
9c8c8af
to
8ebb14c
Compare
Upon digging into bug #1837, I have created a pull request to improve errors verbosity.
Simply put, it logs stacktrace in case of errors.
This change is