KAFKA-4160: Ensure rebalance listener not called with coordinator lock #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Mar 23, 2018
|
Any reason not to merge @dpkp ? |
|
This should not be merged until locking / deadlock issues are addressed. At least it should be rebased onto master after latest lock changes, and then I think we need to look closely at the ensure_active_group changes to make sure locks are maintained. |
wbarnha
suggested changes
Aug 4, 2023
dpkp
force-pushed
the
master
branch
2 times, most recently
from
9c8c8af to
8ebb14c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/KAFKA-4160 . The original fix was intended to support rebalance listeners that may run longer than the session timeout.
This change is