-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console commands #119
base: master
Are you sure you want to change the base?
Console commands #119
Conversation
Seems better to use an optional timeout with a default value rather than hard-coding 30 retries, especially since each request can block for a long time then fail.
I need to make some changes to make the options required options. Please don't merge yet |
Ok, added support for required arguments and renamed |
@@ -0,0 +1,35 @@ | |||
import logging | |||
from optparse import OptionParser, Option, OptionValueError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optparse is marked as deprecated, use argparse instead.
Deprecated since version 2.7: The optparse module is deprecated and will not be developed further; development will continue with the argparse module.
I believe it will be a drop in replacement for the changes you are making.
I think this is a great idea but this no longer merges cleanly. I think we may want to build this in a slightly different way as well. I'll work on a PR as a brain dump to show you what I'm thinking. |
b5e3a14
to
4955582
Compare
This is pretty old and the Kafka world has moved on a bit. At this point, I think this should PR should be rejected in favor of a combination of using Kafka's pre-packaged CLI scripts + adding an |
perhaps. but omar was a close friend who passed away and I have a hard time closing this for personal reasons. |
I'm sorry for your loss. |
9c8c8af
to
8ebb14c
Compare
This adds ConsoleProducer/Consumer classes and 3 simple scripts for producing, consuming, and creating topics. This can be useful for testing and checking the state of things in kafka.
These commands are minimal right now, but more options/features can be added in the future.
How to use:
This change is