This repository has been archived by the owner on Feb 23, 2020. It is now read-only.
EventType::getIdentityTypeEntityFormMode() should return a form mode string #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d return a form mode string.
…tityFormMode().
|
I have added an automated test covering |
|
I've merged this over on freelock/rng. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the event type form, when you select an alternative form mode for a person, it looks like the change is not saved, because when the form is reloaded the default form mode seems to be selected.
I have found that the bug is in
EventType::getIdentityTypeEntityFormMode(). This returns a boolean, while it should return a string representing the selected form mode, according toEntityTypeInterface::getIdentityTypeEntityFormMode().