Fix buffer overflow in Markdown parser #10891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Buffer overflows are not god and it is nice that this can be caught by the mentioned setting. With the "unclosed emphasis" you mean in this case the |
albert-github
added
bug
needinfo
Yes, that is the token problematic for this code. |
albert-github
removed
the
needinfo
doxygen
reviewed
May 24, 2024
This fixes a buffer overflow that happened when parsing a bad Markdown file with an unclosed emphasis nested in other elements, such as ```markdown > __af_err af_flip(af_array *out, const af_array in, const unsigned dim)__ ``` This snippet comes from the ArrayFire repository [1]. The problem was found after the refactoring [2] that introduced std::string_view in the code. The `std::string_view::operator[]` has bounds checking enabled when the macro `_GLIBCXX_ASSERTIONS` is defined, which is the case of Arch Linux build system. [1] https://github.com/arrayfire/arrayfire/blob/0a25d36238aa1eee3b775d3584937ca65b0a1807/docs/pages/matrix_manipulation.md [2] doxygen@f4e3751
lahwaacz
force-pushed
the
markdown-fix-overflow
branch
from
53cdbc0
to
28b51a7
Compare
albert-github
added
the
fixed but not released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a buffer overflow that happened when parsing a bad Markdown file with an unclosed emphasis nested in other elements, such as
> __af_err af_flip(af_array *out, const af_array in, const unsigned dim)__This snippet comes from the ArrayFire repository [1]. The problem was found after the refactoring [2] that introduced std::string_view in the code. The
std::string_view::operator[]has bounds checking enabled when the macro_GLIBCXX_ASSERTIONSis defined, which is the case of Arch Linux build system.[1] https://github.com/arrayfire/arrayfire/blob/0a25d36238aa1eee3b775d3584937ca65b0a1807/docs/pages/matrix_manipulation.md
[2] f4e3751