Skip to content

Fix svcutil endpoint configurations generation #4843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petarpetrovt
Copy link

@petarpetrovt petarpetrovt commented Jun 15, 2022

Fixes #4828

  • CertificateOverTransport
  • IssuedTokenOverTransport - Not sure how IssuedSecurityTokenParameters parameter should be generated.
  • KerberosOverTransport
  • SspiNegotiatedOverTransport - Not sure how requireCancellation parameter should be generated.
  • UserNameOverTransport

@HongGit
Copy link
Contributor

HongGit commented Aug 31, 2022

@petarpetrovt can you please rebase and submit changes to fix the build pipeline issue?

What is your plan for the two unchecked items?

@mos379
Copy link

mos379 commented Nov 8, 2023

Anyone till looking into this?

@petarpetrovt
Copy link
Author

@mos379 nah, feel free to take it :)

@mconnew
Copy link
Member

mconnew commented May 21, 2025

@imcarolwang, can you look at the changes here and see if we're still missing what this change adds? If we are still missing this, can you validate that these changes do the right thing?

@imcarolwang
Copy link
Contributor

We're still missing the changes addressed in this PR, the tool's existing implementation hard code to generate UserNameOverTransportBindingElement when configuring TransportSecurityBindingElement for CustomBinding . This PR generally includes the necessary changes to resolve the issue.

Regarding the unchecked checkbox items mentioned by the author in the PR description, PR #5789 was created attempting to address this. The new PR incorporates all the existing changes from this PR, along with added test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svcutil generating incorrect client for WSHttpBinding with SecurityMode.TransportWithMessageCredential
5 participants