[StaticWebAssets] Cleanup ApplyCompressionNegotiation.cs and ResolveCompressedAssets.cs #48082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiercn
commented
Apr 1, 2025
•
javiercn
commented
- Removes LINQ usages.
- Avoids excessive array amortization.
- Reduces allocations
dotnet-issue-labeler
bot
added
Area-AspNetCore
|
Thanks for your PR, @@javiercn. |
javiercn
changed the base branch from
javiercn/reuse-original-task-item-for-unmodified-assets-and-endpoints
to
main
javiercn
force-pushed
the
javiercn/more-cleanups
branch
from
4c1beb7 to
9e1de78
Compare
javiercn
commented
Apr 4, 2025
| @@ -115,16 +115,22 @@ public override bool Execute() | |||
| // Process the final set of candidate assets, deduplicating assets to be compressed in the same format multiple times and | |||
| // generating new a static web asset definition for each compressed item. | |||
| var formats = SplitPattern(Formats); | |||
| var assetsToCompress = new List<ITaskItem>(); | |||
| var assetsToCompress = new ITaskItem[matchingCandidateAssets.Count * formats.Length]; | |||
There was a problem hiding this comment.
Instead of creating a list and having to turn it into an array, we create an array of the max size we expect to hold and return that directly.
This takes advantage of the fact that MSBuild will ignore any item that is null when reading the outputs from a task, which save us from having to reallocate the list and convert it back into an array of contiguous elements
javiercn
changed the title
javiercn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.