Add back Microsoft.Dotnet.Sdk.Internal project #41154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used by a bunch of repos to pick up the latest SDK: https://github.com/search?q=org%3Adotnet+MicrosoftDotnetSdkInternal+-repo%3Adotnet%2Fdotnet&type=code Add it back until we transition these repos onto another package.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
lewing
approved these changes
May 24, 2024
|
We should also tell the other repos they can adjust their flow to point at Sdk |
|
I've fixed the subscriptions in darc |
|
/backport to release/9.0.1xx-preview5 |
|
Started backporting to release/9.0.1xx-preview5: https://github.com/dotnet/sdk/actions/runs/9226386812 |
MiYanni
requested changes
May 24, 2024
There was a problem hiding this comment.
Wait, why are we adding this back? It was some kind of hacky workaround from 5 years ago in the dotnet/installer repo. I don't want this here. Can we spend time figuring out a proper solution instead of reapplying the duct tape?
CC @marcpopMSFT
|
Ok. I'll keep #41156 to track updating the repos with the new package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by a bunch of repos to pick up the latest SDK: https://github.com/search?q=org%3Adotnet+MicrosoftDotnetSdkInternal+-repo%3Adotnet%2Fdotnet&type=code
Add it back until we transition these repos onto another package.