[NO-REVIEW] Temporary diagnostics for ChaCha20 on Android#129000
Draft
vcsjones wants to merge 4 commits into
Draft
[NO-REVIEW] Temporary diagnostics for ChaCha20 on Android#129000vcsjones wants to merge 4 commits into
vcsjones wants to merge 4 commits into
Conversation
vcsjones
added
NO-MERGE
Member
Author
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional diagnostics for investigating ChaCha20-Poly1305 AEAD behavior on Android, by emitting extra native-side JNI failure information and augmenting the managed test suite with Android-specific diagnostic logging.
Changes:
- Add native diagnostics around
Cipher.updateAAD,Cipher.update, andCipher.doFinalfailure paths in the Android crypto PAL. - Add Android-only test diagnostics (environment + per-case exception details) and wrap an existing tampered-AAD assertion to print extra context when it fails.
Show a summary per file
| File | Description |
|---|---|
| src/native/libs/System.Security.Cryptography.Native.Android/pal_cipher.c | Adds logging/exception printing around JNI cipher operations to help identify failure modes. |
| src/libraries/System.Security.Cryptography/tests/ChaCha20Poly1305Tests.cs | Adds Android-only diagnostic test/logging to capture environment + exception details for failures. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 5
Member
Author
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some temporary diagnostics to see if we can learn something from Android's CI.
This is a pull request to troubleshoot something in CI. IT should not be reviewed, as it will NEVER be merged.