System.DirectoryServices.Protocols: Force using LDAP V3 for SASL binding #109450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
0xced
force-pushed
the
System.DirectoryServices.Protocols-LDAPV3
branch
from
a9c3e8d
to
45c354d
Compare
3 tasks
0xced
force-pushed
the
System.DirectoryServices.Protocols-LDAPV3
branch
from
45c354d
to
35100d4
Compare
0xced
changed the title
steveharter
reviewed
Nov 7, 2024
| @@ -127,6 +127,8 @@ private int BindSasl() | |||
| Marshal.StructureToPtr(defaults, ptrToDefaults, false); | |||
| try | |||
| { | |||
| // Bump up the protocol version because ldap_sasl_interactive_bind requires LDAP V3 else it returns LDAP_NOT_SUPPORTED and this ends up throwing LdapException: The feature is not supported. | |||
| SessionOptions.ProtocolVersion = 3; | |||
There was a problem hiding this comment.
For non-OSX, this must be working before the change above -- will this break V1\V2 users in those cases?
There was a problem hiding this comment.
Actually I don't have a Linux machine to test. I tried to setup Kerberos + OpenLDAP in Docker to test on Linux but I couldn't create a working environment.
This was referenced Nov 16, 2024
Open
|
Note: I used https://github.com/0xced/dotnet-ldap-experiment to test this fix since building the .NET runtime repository and working on it in Rider on macOS is always a challenge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109449