Merge 'main' into Unions#84021
Open
AlekseyTs wants to merge 201 commits into
Open
Conversation
Allow the reference provider to create data points for type and member subkinds while keeping unsupported descriptor kinds filtered out. Use the specific field and event resource strings when reporting reference-count data. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This also includes a new copy of "Optional<T>", as "Opt<T>", so that we can separate IDE and Compiler code, and updates the newly shared pooling code to use "Opt<T>"
Remote.Razor still actually references it, so deployment works, but the compiler doesn't see it.
Bringing in the whole shared project here is overkill, and problematic
Now that pooled objects are in the shared layer, the compiler specific PooledArrayBuilder helper method is inaccessible from the IDE, because the type identities are not the same.
Some of these come from Roslyn, some don't, so the file needs to be split up
It doesn't compile, but fortunately wasn't used :)
This just needs to be any type that comes from the shared library, and `ArgHelper` is ambiguous now
This comes from Roslyn now
This is in the compiler layer, so has access to Optional, but pooling was moved to Opt
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
[main] Source code updates from dotnet/dotnet
These only had one caller left, each
xUnit v2's TestInvoker does not include IAsyncLifetime.InitializeAsync or DisposeAsync in DurationInMs, causing the scheduler to significantly underestimate execution time for tests with expensive async setup (e.g. MEF composition, workspace creation). This led to partitions targeting ~10 minutes consistently running ~30 minutes. Changes: - TestDiscoveryWorker now emits HasAsyncLifetime per test method by checking if the test class implements IAsyncLifetime (directly or via base types) - TestHistoryManager returns theory instance counts alongside durations - AssemblyScheduler applies a 700ms per-theory-instance overhead for tests marked HasAsyncLifetime This is a stop-gap solution until we find a better way to measure the actual IAsyncLifetime overhead, such as computing it from wall-clock timestamps or switching to a test framework that includes it in reported durations. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/roslyn/pull/83915) --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/roslyn/pull/83928)
Implement runtime async support for dynamic. Closes dotnet#79762. Relates to test plan dotnet#75960
Follow up to dotnet#83971 to further bolster the VS Code tests, after a copilot code review comment on that PR found an inconsistency. Essentially, since the VS Code tests use the real product services for the most part, and not test equivalents, and now that all of our types are in the local MEF composition, we can use the "real" MEF instances instead of manually constructing our own. This makes for better test foundation in future, even if none of the current tests run into issues. eg, in the VS Code side the tests could all be changed to stop manually constructing the endpoints, and just use MEF, or potentially even a real LSP request to a server. That's a future time if/when we get rid of the shared projects though. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/roslyn/pull/83986)
…urceText bounds (dotnet#84002) When a document changes rapidly, stale HTML diagnostics can reference positions beyond the current source text length. FilterHTMLDiagnostics now validates diagnostic ranges against the source text before processing, preventing a potential InvalidOperationException in GetTextSpan. Fixes dotnet#83539 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/roslyn/pull/84002)
[main] Source code updates from dotnet/dotnet
This removes the global semaphore that currently exists in ProjectBuildManager, and then enables parallel loading in the LSP when loading projects.
dotnet-policy-service
Bot
added
VSCode
Area-Razor
Needs API Review
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow