Always use DiagnosticHelper.Create for diagnostics with options #73339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/sdk#39142, fixes #73261
IDE0073
was also affected but got fixed by #73263Repro repo on which I tested this PR: https://github.com/js6pak/BrokenCodeStyleAnalyzersRepro
8.0.1xx and this PR should report
IDE0036
,IDE0073
andIDE0130
while 8.0.2xx won't report anything.Even though I think I found all the affected diagnostics, there might be more I missed and this silent breakage when you use
Diagnostic.Create
directly onCustomSeverityConfigurable
diagnostics definitely feels wrong, maybe it should throw if you don't useDiagnosticHelper
?