Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use DiagnosticHelper.Create for diagnostics with options #73339

Merged
merged 1 commit into from
May 31, 2024

Conversation

js6pak
Copy link
Contributor

@js6pak js6pak commented May 4, 2024

Fixes dotnet/sdk#39142, fixes #73261

IDE0073 was also affected but got fixed by #73263

Repro repo on which I tested this PR: https://github.com/js6pak/BrokenCodeStyleAnalyzersRepro
8.0.1xx and this PR should report IDE0036, IDE0073 and IDE0130 while 8.0.2xx won't report anything.

Even though I think I found all the affected diagnostics, there might be more I missed and this silent breakage when you use Diagnostic.Create directly on CustomSeverityConfigurable diagnostics definitely feels wrong, maybe it should throw if you don't use DiagnosticHelper?

@js6pak js6pak requested a review from a team as a code owner May 4, 2024 17:35
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 4, 2024
@CyrusNajmabadi
Copy link
Member

@mavasani @sharwell can you review?

@cremor
Copy link

cremor commented May 31, 2024

Are the CI failures related to the changes in the PR? If not, can we get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE0130 is not reported correctly in 8.0.2xx MSBuild 17.9.4 no longer reports code style errors in build
5 participants