Nullable annotate InMethodyBinder #73270
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in response to dotnet#73022 where there is a null reference exception during binder. The cause is, very likely, a `null` symbol being passed into the binder. It's not possible to fully root cause this at the moment but adding asserts and NRT annotations to help us track it down in the future.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jaredpar
commented
Apr 29, 2024
| @@ -181,6 +181,7 @@ public override Binder VisitMethodDeclaration(MethodDeclarationSyntax methodDecl | |||
| if (usage == NodeUsage.MethodBody) | |||
| { | |||
| method = method ?? GetMethodSymbol(methodDecl, resultBinder); | |||
| Debug.Assert(method is not null); | |||
There was a problem hiding this comment.
@dotnet/roslyn-compiler wanted some feedback here. The two Debug.Assert calls are seemingly very likely identifying the cause for the NRT in #73022. Pretty much every other call in this type to GetMethodSymbol handles null as a valid return value and simply avoids creating the InMethodBinder. I'm leaning towards doing the same here but at the same time I can't find a way to construct a test case that hits the null so I'm reluctant to do that.
AlekseyTs
reviewed
May 1, 2024
| @@ -181,6 +181,7 @@ public override Binder VisitMethodDeclaration(MethodDeclarationSyntax methodDecl | |||
| if (usage == NodeUsage.MethodBody) | |||
| { | |||
| method = method ?? GetMethodSymbol(methodDecl, resultBinder); | |||
| Debug.Assert(method is not null); | |||
|
@jaredpar Is there a crash dump in the original vsfeedback ticket? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #73022 where there is a null reference exception during binder. The cause is, very likely, a
nullsymbol being passed into the binder. It's not possible to fully root cause this at the moment but adding asserts and NRT annotations to help us track it down in the future.