Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RS2007 not allowing table borders #7466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Thomas-Shephard
Copy link

Allows release trackers to have table borders without raising a warning for RS2007.

Fixes #7465

@Thomas-Shephard Thomas-Shephard requested a review from a team as a code owner November 3, 2024 11:56
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (d6e7d82) to head (3538b50).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7466   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files        1448     1448           
  Lines      346895   346895           
  Branches    11404    11404           
=======================================
+ Hits       334755   334761    +6     
+ Misses       9250     9245    -5     
+ Partials     2890     2889    -1     

@mavasani
Copy link
Contributor

mavasani commented Nov 3, 2024

Can you add a unit test for the change?

@Thomas-Shephard
Copy link
Author

@dotnet-policy-service agree

@Thomas-Shephard
Copy link
Author

I've fixed a slight omission in my original pull request where I didn't remove the leading and trailing pipe symbols before the entry parts are parsed.

I've also added some tests for this but happy to add more if you would like, let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Tracker Analyzer RS2007 Does Not Support Table Borders
2 participants