Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source-build team references #7448

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

MichaelSimons
Copy link
Member

The @dotnet/source-build-internal team is being deprecated. All references to it were updated.

Included the renaming of SourceBuild.props to the new naming convention, DotNetBuild.props.

Related to dotnet/source-build#4645

Repo admins, can you please grant write access to @dotnet/source-build and remove any access granted to @dotnet/source-build-internal

@MichaelSimons MichaelSimons requested review from a team as code owners October 11, 2024 19:51
@MichaelSimons MichaelSimons requested review from a team and removed request for a team October 11, 2024 19:52
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (8c173ce) to head (451f502).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7448      +/-   ##
==========================================
- Coverage   96.50%   96.50%   -0.01%     
==========================================
  Files        1448     1448              
  Lines      346869   346869              
  Branches    11402    11402              
==========================================
- Hits       334739   334735       -4     
- Misses       9243     9246       +3     
- Partials     2887     2888       +1     

@MichaelSimons
Copy link
Member Author

Gentle ping @dotnet/roslyn-analysis. Can you please make the requested permission changes so that this PR can be merged? TIA

Repo admins, can you please grant write access to @dotnet/source-build and remove any access granted to @dotnet/source-build-internal

@MichaelSimons
Copy link
Member Author

@jaredpar - Can you help with permissions?

Repo admins, can you please grant write access to @dotnet/source-build and remove any access granted to @dotnet/source-build-internal

@jaredpar
Copy link
Member

@MichaelSimons done

@MichaelSimons MichaelSimons merged commit d6e7d82 into dotnet:main Oct 24, 2024
14 checks passed
@MichaelSimons MichaelSimons deleted the sb-rename branch October 24, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants