Fix a potential NullReferenceException in PlacementWorker
#9386
+18
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Mar 16, 2025
Comment on lines
379
to
385
| if (exception is null) | ||
| { | ||
| // Due to race conditions, it is possible to observe IsFaulted = true, but still Exception = null. | ||
| // This is because the state transition to Faulted might have occurred just after the Exception | ||
| // property check, but before the internal exception was retrieved. | ||
|
|
||
| return new Exception("Task faulted without an exception."); |
There was a problem hiding this comment.
Are you sure about this? I don't believe it's true. If it were, that would be a serious bug in the .NET runtime.
There was a problem hiding this comment.
As I understand it, it is a trade off to avoid locking, see: https://source.dot.net/System.Private.CoreLib/R/0bdc783f2cd45895.html
ReubenBond
force-pushed
the
fix-potential-nre
branch
from
979c7cd to
9b16f21
Compare
ReubenBond
approved these changes
Mar 16, 2025
|
LGTM, thanks @ledjon-behluli! |
ReubenBond
changed the title
PlacementWorkerNullReferenceException in PlacementWorker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a potential issue where
Task.Exceptioncould be null due to race conditions or when tasks were canceled but not explicitly caught by the user. Instead of relying on implicit cancellation handling, this change ensures that exceptions are properly set when needed, preventing unexpected null reference issues in downstream logic.Original thread: https://discord.com/channels/333727978460676096/922945034427432980/threads/1346762281161199668
Microsoft Reviewers: Open in CodeFlow